[llvm] r180099 - Un-revert the environ copy in ProgramTest after fixing it on OS X

[Reid Kleckner]

On Wed, Apr 24, 2013 at 12:12 PM, Nico Rieck <nico.rieck at gmail.com> wrote:
> On 23.04.2013 15:15, Reid Kleckner wrote:
>>
>> Author: rnk
>> Date: Tue Apr 23 08:15:51 2013
>> New Revision: 180099
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=180099&view=rev
>> Log:
>> Un-revert the environ copy in ProgramTest after fixing it on OS X
>>
>> This was r180041 and r180046, which was reverted in r180066.
>> Re-committing this should fix the dragonegg bootstrap, which I presume
>> needs LD_LIBRARY_PATH to be propagated to the child.
>>
>> Tested on Linux, Windows, and Mac OS 10.6.
>>
>> Modified:
>>      llvm/trunk/unittests/Support/ProgramTest.cpp
>
>
> This breaks MSVC builds (e.g.
> <http://bb.pgr.jp/builders/ninja-clang-i686-msc17-R/builds/953/steps/build_llvm/logs/stdio>).
> Did you test with MingW? This can be fixed by using "_environ" from stdlib.h
> instead of "environ".

I think what broke it was the last minute addition of "extern const
char **environ;".  Removing that seems to fix things.  I'll avoid
doing that on Windows.