[PATCH] Tests and interface for LeakSanitizer.

Dmitry Vyukov dvyukov at google.com
Tue Apr 23 01:32:14 PDT 2013



================
Comment at: lib/lsan/lsan_testing_interface.h:1
@@ +1,2 @@
+//=-- lsan_testing_interface.h --------------------------------------------===//
+//
----------------
Sergey Matveev wrote:
> Kostya Serebryany wrote:
> > I am confused. I thought you are going to have this in lsan.h
> > Is this file only for testing lsan itself, or also for actually using lsan? 
> If I merged this into lsan.h now I'd have to submit lsan.h as part of this code review, and then I'd probably have to submit lsan.cc as well. I think it would be a better idea to have this committed as a separate header, and merge it later when I'm submitting lsan proper.
I am concerned about putting source files into top-level dir of the tool.
I would prefer the top-level dir to contain only other subdirs (src, test, etc), probably except build system related files if necessary.


http://llvm-reviews.chandlerc.com/D677

BRANCH
  lsan_interface_and_tests

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list