[llvm] r179974 - SLPVectorizer: Fix a bug in the code that scans the tree in search of nodes with multiple users.

Eric Christopher echristo at gmail.com
Mon Apr 22 10:23:22 PDT 2013


Aha, awesome. Wasn't clear from the commit.

Thanks!

-eric

On Mon, Apr 22, 2013 at 10:05 AM, Nadav Rotem <nrotem at apple.com> wrote:
> It is a bug in a search procedure so it does not affect the output, only the
> compile time.
>
> On Apr 22, 2013, at 7:46 AM, Eric Christopher <echristo at gmail.com> wrote:
>
> Testcase?
>
> -eric
>
> On Sun, Apr 21, 2013 at 12:37 AM, Nadav Rotem <nrotem at apple.com> wrote:
>
> Author: nadav
> Date: Sun Apr 21 02:37:56 2013
> New Revision: 179974
>
> URL: http://llvm.org/viewvc/llvm-project?rev=179974&view=rev
> Log:
> SLPVectorizer: Fix a bug in the code that scans the tree in search of nodes
> with multiple users.
> We did not terminate the switch case and we executed the search routine
> twice.
>
>
> Modified:
>    llvm/trunk/lib/Transforms/Vectorize/VecUtils.cpp
>
> Modified: llvm/trunk/lib/Transforms/Vectorize/VecUtils.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/VecUtils.cpp?rev=179974&r1=179973&r2=179974&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Vectorize/VecUtils.cpp (original)
> +++ llvm/trunk/lib/Transforms/Vectorize/VecUtils.cpp Sun Apr 21 02:37:56
> 2013
> @@ -354,6 +354,7 @@ void BoUpSLP::getTreeUses_rec(ArrayRef<V
>
>         getTreeUses_rec(Operands, Depth+1);
>       }
> +      return;
>     }
>     case Instruction::Store: {
>       ValueList Operands;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>



More information about the llvm-commits mailing list