[patch] Use llvm/Object/MachO.h in macho-dumper

Eric Christopher echristo at gmail.com
Mon Apr 22 03:59:03 PDT 2013


This is a really nice cleanup. The patch itself is pretty large, but
I'm absolutely in favor of having this checked in.

Jim: Any objections?

-eric

On Fri, Apr 19, 2013 at 10:03 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> For Mach-O there are 2 implementations for parsing object files. A
> standalone llvm/Object/MachOObject.h and llvm/Object/MachO.h which
> implements the generic interface in llvm/Object/ObjectFile.h.
>
> This patch adds the missing features to MachO.h, moves macho-dump to
> use MachO.h and removes ObjectFile.h.
>
> In addition to making sure that check-all is clean, I checked that the
> new version produces exactly the same output in all Mach-O files in a
> llvm+clang build directory (including executables and shared
> libraries).
>
> To test the performance, I ran macho-dump over all the files in a
> llvm+clang build directory again, but this time redirecting the output
> to /dev/null. Both the old and new versions take about 4.6 seconds
> (2.5 user) to finish.
>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list