[PATCH] [lld][Driver] Add maximum concurrency option.

Shankar Kalpathi Easwaran shankarke at gmail.com
Sat Apr 20 14:18:25 PDT 2013



================
Comment at: lib/Driver/GnuLdDriver.cpp:200
@@ +199,3 @@
+    StringRef(Arg->getValue()).getAsInteger(10, maxConcurrency);
+    options->setMaxConcurrency(maxConcurrency);
+  }
----------------
There might be a user error if the concurrency he is trying to set is greater than the maximum concurrency allowed. Do you think this should be checked as well ?

================
Comment at: include/lld/Core/Parallel.h:87
@@ +86,3 @@
+
+inline unsigned getDefaultExecutorMaxConcurrency() {
+  return detail::getDefaultExecutorMaxConcurrency();
----------------
this could be a const function.


http://llvm-reviews.chandlerc.com/D698



More information about the llvm-commits mailing list