[PATCH] Tests and interface for LeakSanitizer.

Sergey Matveev earthdok at google.com
Fri Apr 19 10:31:43 PDT 2013



================
Comment at: lib/lsan/tests/lsan_tls_loadable.cc:19
@@ +18,3 @@
+// space (see STATIC_TLS_SURPLUS in glibc).
+__thread void *huge_thread_local_array[(1 << 20) / sizeof(void *)]; // NOLINT
+
----------------
Sergey Matveev wrote:
> Kostya Serebryany wrote:
> > This may not build on anything that doesn't have __thread. 
> > Do you plan to build this tests only on proper systems? Otherwise you need to guard the whole test with something (#if LEAK_SANITIZER?)
> > 
> > Also, why NOLINT? (Why not use sizeof(uptr)?)
> > Do you plan to build this tests only on proper systems?
> 
> Yes. Building something called lsan_tls_loadable.so on systems with no tls would only cause confusion.
> 
> NOLINT - fixed
Actually, this file doesn't use any sanitizer headers, so I'll just keep the NOLINT if you don't mind.


http://llvm-reviews.chandlerc.com/D677

BRANCH
  lsan_interface_and_tests

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list