[PATCH] Fix decoding of ARM mov/movt/movw writing sp operand

Mihail Popa mihail.popa at gmail.com
Fri Apr 19 02:18:30 PDT 2013


Well, it does look that way but it's not.
Unfortunately DecodeGPRnopcRegisterClass is impure - once called it may
modify the instruction.
Remove any one of those statements and some tests will fail.. ugly.

Mihai


On Fri, Apr 19, 2013 at 9:32 AM, Tim Northover <t.p.northover at gmail.com>wrote:

> Hi Mihail,
>
> > Please review this simple instruction decoding fix.
>
> Am I missing something, or are two those if statements doing exactly
> the same thing? The first one seems redundant.
>
> Other than that, it looks fine to me.
>
> Tim.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130419/c8361311/attachment.html>


More information about the llvm-commits mailing list