[PATCH] Bugfix for debug intrinsic handling in InstCombiner

Eric Christopher echristo at gmail.com
Tue Apr 16 10:56:37 PDT 2013


I'm not sure it's straightforward at all please tell me why you think so?

This comes down to whether or not the fix is best done in
LowerDbgDeclare or elsewhere. I'm guessing what's happening is that
the alloca for the original loads and stores have been nuked (likely
by mem2reg) and therefore the assumptions through large portions of
the backend aren't holding anymore. These assumptions are an
unfortunate problem we've inherited. I don't have any visibility about
how the testcase was produced (and yes, it definitely needs cleanup)
and don't know how the IR got into the current state. I completely
agree there's a lot of nasty problems in how we deal with non-alloca
variables and value tracking. What's your longer term plan for dealing
with the problem more generally?

Thanks!

-eric

On Tue, Apr 16, 2013 at 9:50 AM, Adrian Prantl <aprantl at apple.com> wrote:
>
> On Apr 16, 2013, at 9:25 AM, Bob Wilson <bob.wilson at apple.com> wrote:
>>
>> The second patch is also OK.  If you can do anything to pare down the test case, especially the metadata, please do.  This could have been reviewed after it was committed, since you're just fixing a bug and the fix is straightforward.
>
> That’s fine. I can commit straightforward bug fixes directly and have them reviewed after commit. I assume Eric (as the code owner) will let me know if my definition of “straightforward” differs from his :-)
>
> -- adrian




More information about the llvm-commits mailing list