[PATCH] Bugfix for debug intrinsic handling in InstCombiner

[Bob Wilson]

On Apr 11, 2013, at 2:18 PM, Adrian Prantl <aprantl at apple.com> wrote:

> Bugfix for the debug intrinsic handling in InstCombiner:
> Since we can't guarantee that the original dbg.declare instrinsic is removed
> by LowerDbgDeclare(), we need to make sure that we are not inserting the same
> dbg.value intrinsic over and over. 
> 
> This removes tons of redundant DIEs when compiling optimized code.
> 
> rdar://problem/13056109


The first patch is obviously fine since it's just removing comments.  You should just commit changes like that without asking for a review.

The second patch is also OK.  If you can do anything to pare down the test case, especially the metadata, please do.  This could have been reviewed after it was committed, since you're just fixing a bug and the fix is straightforward.