[PATCH] Combine bit test + conditional or into simple math

David Majnemer david.majnemer at gmail.com
Sun Apr 14 23:28:25 PDT 2013


On Sun, Apr 14, 2013 at 8:49 PM, Nick Lewycky <nicholas at mxc.ca> wrote:

> Please add asserts that C1 and C2 aren't zero (it would miscompile those
> cases). Looks good!
>

That shouldn't be needed, the code grabs C1 and C2 via m_Power2. However,
the comment that describes the function does deserve a clearer comment.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130414/dc80b6e1/attachment.html>


More information about the llvm-commits mailing list