[llvm] r179475 - SLPVectorizer: Add support for trees that don't start at binary operators, and add the cost of extracting values from the roots of the tree.

Eric Christopher echristo at gmail.com
Sun Apr 14 16:37:46 PDT 2013


Saw your patch updating it, thanks.

Thought that the original problem was irritating enough to fix real
fast so I tried to do that in r179497

so that if you specify a triple to opt it'll set the target data
layout. But it apparently broke some random stuff
so I'll figure out what's up.

-eric


On Sun, Apr 14, 2013 at 11:53 AM, Eric Christopher <echristo at gmail.com> wrote:
> On Sat, Apr 13, 2013 at 10:40 PM, Nadav Rotem <nrotem at apple.com> wrote:
>>
>> On Apr 13, 2013, at 10:25 PM, Eric Christopher <echristo at gmail.com> wrote:
>>
>> Pretty sure you don't need the triple or data layout if you're just
>> overriding it anyhow.
>>
>>
>>
>> We do need the data-layout because opt initializes the DataLayout analysis
>> from the data-layout string in the module.
>
> Hmm.. it should be able to construct a default one from the triple I
> think, but that's a different problem.  At any rate you've got a
> triple for a 64-bit platform in your command line and a 32-bit triple
> and data layout in the module. Which is it? :)
>
> -eric



More information about the llvm-commits mailing list