R600 Patches (Plus one for SI): Various fixes to get the piglit all_cl tests to stop hanging

[Vincent Lejeune]

----- Mail original -----
> De : Tom Stellard <tom at stellard.net>
> À : Alex Deucher <alexdeucher at gmail.com>
> Cc : llvm-commits at cs.uiuc.edu
> Envoyé le : Vendredi 12 avril 2013 23h25
> Objet : Re: R600 Patches (Plus one for SI): Various fixes to get the piglit
	all_cl tests to stop hanging
> 
> On Fri, Apr 12, 2013 at 05:11:25PM -0400, Alex Deucher wrote:
>>  On Fri, Apr 12, 2013 at 4:52 PM, Tom Stellard <tom at stellard.net> 
> wrote:
>>  > Hi,
>>  >
>>  > Attached are several patches to get the piglit test suite to complete 
> a
>>  > full run with all_cl.tests without locking up on my Juniper.
>>  >
>>  > Please Review.
>> 
>>  > From ca217819c518e4de2f2dcc3e9044ccb2375b1474 Mon Sep 17 00:00:00 2001
>>  > From: Tom Stellard <thomas.stellard at amd.com>
>>  > Date: Wed, 10 Apr 2013 14:53:58 -0400
>>  > Subject: [PATCH 4/8] R600: Emit RETURN instructions as a NOP with End 
> of Program bit set
>> 
>>  Will this cause problems on vliw4 (cayman/tn) hardware?
>> 
> 
> Yes, I forgot about this. I will fix it.
> 
>>  > From c0cb56a4e2bb43e0caaf0b6c080b72a34bc4a075 Mon Sep 17 00:00:00 2001
>>  > From: Tom Stellard <thomas.stellard at amd.com>
>>  > Date: Wed, 10 Apr 2013 14:55:16 -0400
>>  > Subject: [PATCH 5/8] R600: limit vtx clauses to one instructions
>>  >
>>  > This fixes incorrect address calculations when multiple vtx 
> instructions
>>  > are in the same clause.
>> 
>>  Maybe add a comment with the actual hw limits so this doesn't cause
>>  confusion if we fix it down the road?
>> 
> 
> Sure.

I think this patch may break some non compute shader.
Mesa can create non unitary VTX clause for vertex/fragment shader, it splits them just in case of compute shader
(which is likely a bug).
I'm working on emitting native tex clause (which should solve the issue) but in the meantime, you can check for program type
(it's stored R600MachineFunction) before changing MaxFetchClause value.

Vincent

> 
> -Tom
> 
>>  Alex
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>