[llvm] r179407 - [ms-inline asm] Move this logic into a static function as it's only applicable

[Chad Rosier]

Author: mcrosier
Date: Fri Apr 12 15:20:54 2013
New Revision: 179407

URL: http://llvm.org/viewvc/llvm-project?rev=179407&view=rev
Log:
[ms-inline asm] Move this logic into a static function as it's only applicable
when parsing MS-style inline assembly.  No functional change intended.

Modified:
    llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp

Modified: llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp?rev=179407&r1=179406&r2=179407&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp Fri Apr 12 15:20:54 2013
@@ -1120,6 +1120,68 @@ X86AsmParser::CreateMemForInlineAsm(unsi
                                End, Size, SymName);
 }
 
+static void
+RewriteIntelBracExpression(SmallVectorImpl<AsmRewrite> *AsmRewrites,
+                           StringRef SymName, int64_t ImmDisp,
+                           int64_t FinalImmDisp, SMLoc &BracLoc,
+                           SMLoc &StartInBrac, SMLoc &End) {
+  // Remove the '[' and ']' from the IR string.
+  AsmRewrites->push_back(AsmRewrite(AOK_Skip, BracLoc, 1));
+  AsmRewrites->push_back(AsmRewrite(AOK_Skip, End, 1));
+
+  // If ImmDisp is non-zero, then we parsed a displacement before the
+  // bracketed expression (i.e., ImmDisp [ BaseReg + Scale*IndexReg + Disp])
+  // If ImmDisp doesn't match the displacement computed by the state machine
+  // then we have an additional displacement in the bracketed expression.
+  if (ImmDisp != FinalImmDisp) {
+    if (ImmDisp) {
+      // We have an immediate displacement before the bracketed expression.
+      // Adjust this to match the final immediate displacement.
+      bool Found = false;
+      for (SmallVectorImpl<AsmRewrite>::iterator I = AsmRewrites->begin(),
+             E = AsmRewrites->end(); I != E; ++I) {
+        if ((*I).Loc.getPointer() > BracLoc.getPointer())
+          continue;
+        if ((*I).Kind == AOK_ImmPrefix) {
+          (*I).Kind = AOK_Imm;
+          (*I).Len = BracLoc.getPointer() - (*I).Loc.getPointer();
+          (*I).Val = FinalImmDisp;
+          Found = true;
+          break;
+        }
+      }
+      assert (Found && "Unable to rewrite ImmDisp.");
+    } else {
+      // We have a symbolic and an immediate displacement, but no displacement
+      // before the bracketed expression.
+      
+      // Put the immediate displacement before the bracketed expression.
+      AsmRewrites->push_back(AsmRewrite(AOK_Imm, BracLoc, 0,
+                                        FinalImmDisp));
+    }
+  }
+  // Remove all the ImmPrefix rewrites within the brackets.
+  for (SmallVectorImpl<AsmRewrite>::iterator I = AsmRewrites->begin(),
+         E = AsmRewrites->end(); I != E; ++I) {
+    if ((*I).Loc.getPointer() < StartInBrac.getPointer())
+      continue;
+    if ((*I).Kind == AOK_ImmPrefix)
+      (*I).Kind = AOK_Delete;
+  }
+  const char *SymLocPtr = SymName.data();
+  // Skip everything before the symbol.        
+  if (unsigned Len = SymLocPtr - StartInBrac.getPointer()) {
+    assert(Len > 0 && "Expected a non-negative length.");
+    AsmRewrites->push_back(AsmRewrite(AOK_Skip, StartInBrac, Len));
+  }
+  // Skip everything after the symbol.
+  if (unsigned Len = End.getPointer() - (SymLocPtr + SymName.size())) {
+    SMLoc Loc = SMLoc::getFromPointer(SymLocPtr + SymName.size());
+    assert(Len > 0 && "Expected a non-negative length.");
+    AsmRewrites->push_back(AsmRewrite(AOK_Skip, Loc, Len));
+  }
+}
+
 X86Operand *X86AsmParser::ParseIntelBracExpression(unsigned SegReg, SMLoc Start,
                                                    uint64_t ImmDisp,
                                                    unsigned Size) {
@@ -1202,70 +1264,12 @@ X86Operand *X86AsmParser::ParseIntelBrac
 
   const MCExpr *Disp;
   if (const MCExpr *Sym = SM.getSym()) {
+    // A symbolic displacement.
     Disp = Sym;
-
-    if (isParsingInlineAsm()) {
-      // Remove the '[' and ']' from the IR string.
-      InstInfo->AsmRewrites->push_back(AsmRewrite(AOK_Skip, BracLoc, 1));
-      InstInfo->AsmRewrites->push_back(AsmRewrite(AOK_Skip, End, 1));
-
-      // If ImmDisp is non-zero, then we parsed a displacement before the
-      // bracketed expression (i.e., ImmDisp [ BaseReg + Scale*IndexReg + Disp])
-      uint64_t FinalImmDisp = SM.getImmDisp();
-
-      // If ImmDisp doesn't match the displacement computed by the state machine
-      // then we have an additional displacement in the bracketed expression.
-      if (ImmDisp != FinalImmDisp) {
-        if (ImmDisp) {
-          // We have an immediate displacement before the bracketed expression.
-          // Adjust this to match the final immediate displacement.
-          bool Found = false;
-          for (SmallVectorImpl<AsmRewrite>::iterator
-                 I = InstInfo->AsmRewrites->begin(),
-                 E = InstInfo->AsmRewrites->end(); I != E; ++I) {
-            if ((*I).Loc.getPointer() > BracLoc.getPointer())
-              continue;
-            if ((*I).Kind == AOK_ImmPrefix) {
-              (*I).Kind = AOK_Imm;
-              (*I).Len = BracLoc.getPointer() - (*I).Loc.getPointer();
-              (*I).Val = FinalImmDisp;
-              Found = true;
-              break;
-            }
-          }
-          assert (Found && "Unable to rewrite ImmDisp.");
-        } else {
-          // We have a symbolic and an immediate displacement, but no displacement
-          // before the bracketed expression.
-        
-          // Put the immediate displacement before the bracketed expression.
-          InstInfo->AsmRewrites->push_back(AsmRewrite(AOK_Imm, BracLoc, 0,
-                                                      FinalImmDisp));
-        }
-      }
-      // Remove all the ImmPrefix rewrites within the brackets.
-      for (SmallVectorImpl<AsmRewrite>::iterator
-             I = InstInfo->AsmRewrites->begin(),
-             E = InstInfo->AsmRewrites->end(); I != E; ++I) {
-        if ((*I).Loc.getPointer() < StartInBrac.getPointer())
-          continue;
-        if ((*I).Kind == AOK_ImmPrefix)
-          (*I).Kind = AOK_Delete;
-      }
-      StringRef SymName = SM.getSymName();
-      const char *SymLocPtr = SymName.data();
-      // Skip everything before the symbol.        
-      if (unsigned Len = SymLocPtr - StartInBrac.getPointer()) {
-        assert(Len > 0 && "Expected a non-negative length.");
-        InstInfo->AsmRewrites->push_back(AsmRewrite(AOK_Skip, StartInBrac, Len));
-      }
-      // Skip everything after the symbol.
-      if (unsigned Len = End.getPointer() - (SymLocPtr + SymName.size())) {
-        SMLoc Loc = SMLoc::getFromPointer(SymLocPtr + SymName.size());
-        assert(Len > 0 && "Expected a non-negative length.");
-        InstInfo->AsmRewrites->push_back(AsmRewrite(AOK_Skip, Loc, Len));
-      }
-    }
+    if (isParsingInlineAsm())
+      RewriteIntelBracExpression(InstInfo->AsmRewrites, SM.getSymName(),
+                                 ImmDisp, SM.getImmDisp(), BracLoc, StartInBrac,
+                                 End);
   } else {
     // An immediate displacement only.
     Disp = MCConstantExpr::Create(SM.getImmDisp(), getContext());