[PATCH] Fix undefined behavior in AArch64

Quentin Colombet qcolombet at apple.com
Thu Apr 11 09:40:47 PDT 2013


Hi David,

LGTM.

Do you think you can come up with a test case?
I know it may be hard since 64 bits shifts yield undefined behavior, therefore you may not be able to make your test case fail before your patch, but if you can it would be good.

Thanks, 

-Quentin

On Apr 10, 2013, at 6:29 PM, David Majnemer <david.majnemer at gmail.com> wrote:

> Hi,
> 
> A64Imms::isLogicalImmBits and A64Imms::isLogicalImm try to perform 64 bit rotations. 
> The attached diff avoids these rotations when detected.
> 
> Thanks,
> David Majnemer
> <aarch64_ub.diff>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130411/76090e00/attachment.html>


More information about the llvm-commits mailing list