[llvm] r179226 - No need to have this return a bool.

Bill Wendling isanbard at gmail.com
Wed Apr 10 15:03:59 PDT 2013


Author: void
Date: Wed Apr 10 17:03:59 2013
New Revision: 179226

URL: http://llvm.org/viewvc/llvm-project?rev=179226&view=rev
Log:
No need to have this return a bool.

Modified:
    llvm/trunk/lib/MC/MCDwarf.cpp

Modified: llvm/trunk/lib/MC/MCDwarf.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCDwarf.cpp?rev=179226&r1=179225&r2=179226&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCDwarf.cpp (original)
+++ llvm/trunk/lib/MC/MCDwarf.cpp Wed Apr 10 17:03:59 2013
@@ -899,7 +899,7 @@ namespace {
     /// EmitCompactUnwind - Emit the unwind information in a compact way. If
     /// we're successful, return 'true'. Otherwise, return 'false' and it will
     /// emit the normal CIE and FDE.
-    bool EmitCompactUnwind(MCStreamer &streamer,
+    void EmitCompactUnwind(MCStreamer &streamer,
                            const MCDwarfFrameInfo &frame);
 
     const MCSymbol &EmitCIE(MCStreamer &streamer,
@@ -1139,7 +1139,7 @@ void FrameEmitterImpl::EmitCFIInstructio
 /// EmitCompactUnwind - Emit the unwind information in a compact way. If we're
 /// successful, return 'true'. Otherwise, return 'false' and it will emit the
 /// normal CIE and FDE.
-bool FrameEmitterImpl::EmitCompactUnwind(MCStreamer &Streamer,
+void FrameEmitterImpl::EmitCompactUnwind(MCStreamer &Streamer,
                                          const MCDwarfFrameInfo &Frame) {
   MCContext &Context = Streamer.getContext();
   const MCObjectFileInfo *MOFI = Context.getObjectFileInfo();
@@ -1168,6 +1168,8 @@ bool FrameEmitterImpl::EmitCompactUnwind
   //   .quad except_tab1
 
   uint32_t Encoding = Frame.CompactUnwindEncoding;
+  if (!Encoding) return;
+
   bool DwarfEHFrameOnly = (Encoding == MOFI->getCompactUnwindDwarfEHFrameOnly());
 
   // The encoding needs to know we have an LSDA.
@@ -1209,8 +1211,6 @@ bool FrameEmitterImpl::EmitCompactUnwind
     Streamer.EmitSymbolValue(Frame.Lsda, Size);
   else
     Streamer.EmitIntValue(0, Size); // No LSDA
-
-  return true;
 }
 
 const MCSymbol &FrameEmitterImpl::EmitCIE(MCStreamer &streamer,





More information about the llvm-commits mailing list