[Mesa-dev] [PATCH v2] R600/SI: Add pattern for AMDGPUurecip

Christian König deathsimple at vodafone.de
Wed Apr 10 03:59:07 PDT 2013


Am 10.04.2013 12:21, schrieb Michel Dänzer:
> On Mit, 2013-04-10 at 12:07 +0200, Christian König wrote:
>> Am 10.04.2013 11:46, schrieb Michel Dänzer:
>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>
>>> 21 more little piglits with radeonsi.
>>>
>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>> You figured it out, great!
> I figured out what? :) This is the same patch I sent out a couple of
> weeks ago as a followup in one of your patch series.
>
>
>> But why the heck is multiplying with 0x4f800000 fixing the result?
> I'm afraid I can't explain how it works, I basically copied it from the
> Cayman section in R600Instructions.td...
>

Looks like I missed the original patch. Two or tree weeks ago I was 
trying to get that working also, but didn't stumbled over the Cayman 
implementation and so couldn't find the right solution.

Anyway even if I can't explain exactly why it seems to work fine on both 
Cayman and SI, so the patch is:

Reviewed-by: Christian König <christian.koenig at amd.com>

Christian.



More information about the llvm-commits mailing list