Bug fix in Tblgen

[Jakob Stoklund Olesen]

On Apr 7, 2013, at 3:53 AM, "Malul, Elior" <elior.malul at intel.com> wrote:

> I think what you say make sense, since after all what I did is a solution to the problem, not to the problem itself.
> The downside is that we will need to make another 'resolve mechanism' (since the current resolve mechanism only resolves fields).
> Are you OK with that?

Yes.

I think the 'foreach' iteration variables should be lexically scoped, and not dynamically scoped like the 'let' bindings.

This would mean that you recognize them as iteration variables while parsing the defs inside a foreach loop, instead of back-substituting after parsing as it is currently done.

BTW, the whole Init::resolveReferencesTo() system is pretty slow, walking the entire expression tree for every variable substitution. If you can think of a faster way, that would be great.

/jakob