[llvm] r178854 - Buildbot fix for r178851: mistake was in wrong TargetRegisterInfo::getRegClass usage.

Renato Golin renato.golin at linaro.org
Fri Apr 5 11:36:30 PDT 2013


On 5 April 2013 19:26, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:


> That's not right either. How are you testing this code? Please don't just
> guess.
>
> You should probably be using QPRRegClass.contains().
>

Hi Jacob,

I have reverted this (and the original) patch already. This is not right
and there isn't enough tests to make me sleep at night.

Unless I see clear evidence that a patch in that area is actually doing
what it should (via review of someone that knows it, like you) AND proper
tests are passing (including the test-suite on ARM), it'll remain reverted.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130405/a06ad414/attachment.html>


More information about the llvm-commits mailing list