[PATCH] Fixes in LargeMmapAllocator::GetBlockBegin().

Sergey Matveev earthdok at google.com
Fri Apr 5 07:49:55 PDT 2013



================
Comment at: lib/sanitizer_common/sanitizer_allocator.h:1019
@@ -1018,1 +1018,3 @@
+      return 0;
+    if (h->map_beg + page_size_ > p)
       return 0;
----------------
Kostya Serebryany wrote:
> you've changed two checks but added one test
> did you run the asan tests? 
Yes, I did.
Should I create a regression test for this specific boundary condition? That seems a bit excessive.


http://llvm-reviews.chandlerc.com/D624



More information about the llvm-commits mailing list