[PATCH] Run the callback on a separate stack in StopTheWorld.

Alexander Potapenko glider at google.com
Mon Apr 1 07:25:39 PDT 2013



================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld_linux.cc:256
@@ +255,3 @@
+    guard_size_ = GetPageSizeCached();
+    // XXX: Omitting MAP_STACK here works in current kernels but might break in
+    // the future.
----------------
s/XXX/FIXME
Searching compiler-rt for "XXX:" shows only namespace names ("XXX::YYY::ZZZ") in our tests
Searching for "XXX" I see several uses of "XXX" as a todo marker (all outside libsanitizer), and a bunch of XXXes in libsanitizer, all meaning "foobar".


http://llvm-reviews.chandlerc.com/D592



More information about the llvm-commits mailing list