[llvm] r178366 - Use 12 as the magic number for our abbreviation data and our

Eric Christopher echristo at gmail.com
Fri Mar 29 14:20:40 PDT 2013


On Fri, Mar 29, 2013 at 2:14 PM, Chandler Carruth <chandlerc at google.com> wrote:
> On Fri, Mar 29, 2013 at 1:23 PM, Eric Christopher <echristo at gmail.com>
> wrote:
>>
>> Author: echristo
>> Date: Fri Mar 29 15:23:06 2013
>> New Revision: 178366
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=178366&view=rev
>> Log:
>> Use 12 as the magic number
>
>
> of inline elements in the small vectors
>
>>
>> for our abbreviation data and our
>> die values. A lot of DIEs have 10 attributes in C++ code (example
>> clang), none had more than 12. Seems like a good default.
>
>
> There, fixed that commit log for ya. ;] Seriously, i thought you were
> writing "12" into the debug output at first.
>
> Also, should this maybe be a constant with a name somewhere for the day when
> we need it to be 16?
>

Could, just thought that 32 was a bit large. I'll add a comment about
it and just have it
with a single use by using impls.

-eric



More information about the llvm-commits mailing list