SmallVector and SmallPtrSet allocations not power-of-two aligned

Sean Silva silvas at purdue.edu
Wed Mar 27 17:44:14 PDT 2013


On Wed, Mar 27, 2013 at 5:42 PM, Jean-Luc Duprat <jduprat at apple.com> wrote:

> These changes moved all the allocations identified above to proper
> power-of-two allocations.  These changes have no impact on performance, but
> will help pool memory allocations together if needed.
>
>

Have you dug into why the existing code is written so that the end iterator
always points at valid memory? That is mentioned in multiple comments. It
seems weird to do that, but I wouldn't change it without investigating why
that was done in the first place.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130327/3b1873ab/attachment.html>


More information about the llvm-commits mailing list