[PATCH] Enable partial update depency breaking for A15

[Silviu Baranga]

Committed in r 178134. Thanks!

- Silviu

From: Renato Golin [mailto:renato.golin at linaro.org]
Sent: 27 March 2013 10:51
To: Silviu Baranga
Cc: llvm-commits at cs.uiuc.edu for LLVM
Subject: RE: [PATCH] Enable partial update depency breaking for A15


LGTM

cheers,
Renato
On 27 Mar 2013 10:41, "Silviu Baranga" <Silviu.Baranga at arm.com<mailto:Silviu.Baranga at arm.com>> wrote:
Hi Renato,

I've modified the patch according to your comments. The tests should
now be much better documented.

Is it ok to commit?

Cheers,
Silviu

From: Renato Golin [mailto:renato.golin at linaro.org<mailto:renato.golin at linaro.org>]
Sent: 26 March 2013 21:57
To: Silviu Baranga
Cc: Commit Messages and Patches for LLVM
Subject: Re: [PATCH] Enable partial update depency breaking for A15

On 26 March 2013 21:48, Silviu Baranga <Silviu.Baranga at arm.com<mailto:Silviu.Baranga at arm.com>> wrote:
I should have added some comments to these tests (will do so tomorrow).
The generated code uses a vld1.32 instruction to write the lane 1 of a D register
containing the value of <2 x float> %B. Since the D register is defined, it would
be incorrect to fully write it (with a vmov.f64) before the vld1.32 instruction.
Test checks that a vmov.f64 was not generated.

Oh, I see. Makes sense. That as a comment would be great in the test. ;)


It could be anything that writes the D register, it doesn't matter. The
existing code uses a FCONSTD (vmov.f64) to write the D register before the
vld1.32 instruction (or other instructions that partially update D registers)
in order to break the existing dependencies on the D register.

That's what I though, ok. It'd be better to test for something a bit more generic, since it could be many other types of VMOVs on D regs.

Maybe:

; CHECK: vmov{{.*}}d{{[0-9]+}},

or something. It also makes it more explicit what you're expecting, leaving less need for a comment right before it.


Thanks!
--renato

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130327/e20596e3/attachment.html>