[llvm] r177730 - R600: Use legacy (0 * anything = 0) MUL instructions for pow intrinsics

Christian König christian.koenig at amd.com
Tue Mar 26 10:50:48 PDT 2013


Am 26.03.2013 18:18, schrieb Rafael Espíndola:
>> As Michel already wrote in the commit message, it fixes two piglit tests and
>> so doesn't need to be covered by any llvm tests.
>>
>> While it might make sense for some low level instructions to be covered by
>> llvm tests, it probably doesn't make any sense for complex behavior changes
>> like this one, since they are covered pretty well by piglit.
> That is not the case at all! Please check the developer policy:
>
> http://llvm.org/docs/DeveloperPolicy.html#test-cases

I know the policy, but it still doesn't make much sense for us covering 
the same code by two different unit testing frameworks.

Christian.

>
>> Christian.
>>
> Cheers,
> Rafael
>






More information about the llvm-commits mailing list