[llvm] r178031 - Make InstCombineCasts.cpp:OptimizeIntToFloatBitCast endian safe.

Duncan Sands baldrick at free.fr
Tue Mar 26 10:20:41 PDT 2013


On 26/03/13 18:12, Ulrich Weigand wrote:
> Duncan Sands <duncan.sands at gmail.com> wrote on 26.03.2013 18:00:50:
>> On 26/03/13 17:46, Ulrich Weigand wrote:
>>> Hmm, it fixed an existing test case failure for me on PowerPC.
>>> But I can try and see if I manage to extract a .ll level test case.
>>
>> yes please, that way people not on PowerPC will notice if they break
> this.
>
> Right.  It turns out there was an existing test case for this feature
> on a little-endian target; in the attached patch I'm adding a copy of
> the test for a big-endian target and verify that we get the correct
> element indices there.  Does this look OK?

LGTM.  Thanks for doing this!

Ciao, Duncan.




More information about the llvm-commits mailing list