[PATCH] Fix DecodeT2LdStPre

Joe Abbey jabbey at arxan.com
Tue Mar 26 07:01:58 PDT 2013


On Mar 26, 2013, at 2:06 AM, Bill Wendling <wendling at apple.com> wrote:

> On Mar 25, 2013, at 2:42 PM, Joe Abbey <jabbey at arxan.com> wrote:
> 
>> Patch by Gordon Keiser, with test case!
>> 
>> This patch addresses failure to decode encoding T4 of LDR (A8.8.62) and is a postindexed load, where the offset 0xc is applied to SP after the load occurs.   Rn is decoded with DecodeGPRRegisterClass but Rt is decoded (in what I assume is either a typo or misreading of the ARM manuals) with DecoderGPRRegisterClass.   Note the wonderful differentiation with the lowercase "r".   In any case, if PC or SP is the destination, the disassembler erroneously failed with the invalid encoding, despite the manual saying that both are fine.   
>> 
> Ew...the names are unfortunate. Is there a better name than DecoderGPRegisterClass?
> 
>> Ok to commit?
>> 
> LGTM. Thanks!

Committed in r178017.

Joe



More information about the llvm-commits mailing list