[PATCH] PR15413: Assertion "SE.DT->dominates(Ret, BIP)" fails.

[Andrew Trick]

On Mar 13, 2013, at 3:17 PM, Andrew Trick <atrick at apple.com> wrote:
> Please review this patch. It addresses a fundamental problem with SSA update. There have been attempts to fix and work around it, but they only hide the problem. I believe this patch moves in the right direction.
> 
> We still need to do something about the interaction between LCSSA and SCEV (LCSSA should be removed), and metadata operands are still not updated correctly (SSA updater needs to handle handles).
> 
> In this particular case, both LCSSA and SSA updater were incorrectly updating SCEV such that SCEVExpander would blow up later in the vectorizer. This needed to be fixed without regressing on previous efforts to avoid total SCEV invalidation and preserve correct behavior when updating other ValueHandles as seen in PR12901.

This does fix a real bug, and I don't really need a review. But it's an interesting enough problem I think someone should take a look at it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr15413.patch
Type: application/octet-stream
Size: 16756 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130325/c8fa1332/attachment.obj>