[llvm] r177827 - Cleanup some unused reg. scavenger parameters in PPCRegisterInfo

Hal Finkel hfinkel at anl.gov
Sat Mar 23 12:36:47 PDT 2013


Author: hfinkel
Date: Sat Mar 23 14:36:47 2013
New Revision: 177827

URL: http://llvm.org/viewvc/llvm-project?rev=177827&view=rev
Log:
Cleanup some unused reg. scavenger parameters in PPCRegisterInfo

These spilling functions will eventually make use of the register scavenger,
however, they'll do so by taking advantage of PEI's virtual-register-based
delayed scavenging mechanism. As a result, these function parameters will not
be used, and can be removed.

No functionality change intended.

Modified:
    llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.cpp
    llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.h

Modified: llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.cpp?rev=177827&r1=177826&r2=177827&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.cpp Sat Mar 23 14:36:47 2013
@@ -203,8 +203,7 @@ PPCRegisterInfo::getRegPressureLimit(con
 ///   stwxu  R0, SP, Rnegsize   ; add and update the SP with the negated size
 ///   addi   Rnew, SP, \#maxCalFrameSize ; get the top of the allocation
 ///
-void PPCRegisterInfo::lowerDynamicAlloc(MachineBasicBlock::iterator II,
-                                        int SPAdj, RegScavenger *RS) const {
+void PPCRegisterInfo::lowerDynamicAlloc(MachineBasicBlock::iterator II) const {
   // Get the instruction.
   MachineInstr &MI = *II;
   // Get the instruction's basic block.
@@ -300,8 +299,7 @@ void PPCRegisterInfo::lowerDynamicAlloc(
 ///   stw rA, FI               ; Store rA to the frame.
 ///
 void PPCRegisterInfo::lowerCRSpilling(MachineBasicBlock::iterator II,
-                                      unsigned FrameIndex, int SPAdj,
-                                      RegScavenger *RS) const {
+                                      unsigned FrameIndex) const {
   // Get the instruction.
   MachineInstr &MI = *II;       // ; SPILL_CR <SrcReg>, <offset>
   // Get the instruction's basic block.
@@ -311,8 +309,6 @@ void PPCRegisterInfo::lowerCRSpilling(Ma
   // FIXME: Once LLVM supports creating virtual registers here, or the register
   // scavenger can return multiple registers, stop using reserved registers
   // here.
-  (void) SPAdj;
-  (void) RS;
 
   bool LP64 = Subtarget.isPPC64();
   unsigned Reg = LP64 ? PPC::X0 : PPC::R0;
@@ -342,8 +338,7 @@ void PPCRegisterInfo::lowerCRSpilling(Ma
 }
 
 void PPCRegisterInfo::lowerCRRestore(MachineBasicBlock::iterator II,
-                                      unsigned FrameIndex, int SPAdj,
-                                      RegScavenger *RS) const {
+                                      unsigned FrameIndex) const {
   // Get the instruction.
   MachineInstr &MI = *II;       // ; <DestReg> = RESTORE_CR <offset>
   // Get the instruction's basic block.
@@ -353,8 +348,6 @@ void PPCRegisterInfo::lowerCRRestore(Mac
   // FIXME: Once LLVM supports creating virtual registers here, or the register
   // scavenger can return multiple registers, stop using reserved registers
   // here.
-  (void) SPAdj;
-  (void) RS;
 
   bool LP64 = Subtarget.isPPC64();
   unsigned Reg = LP64 ? PPC::X0 : PPC::R0;
@@ -383,8 +376,7 @@ void PPCRegisterInfo::lowerCRRestore(Mac
 }
 
 void PPCRegisterInfo::lowerVRSAVESpilling(MachineBasicBlock::iterator II,
-                                      unsigned FrameIndex, int SPAdj,
-                                      RegScavenger *RS) const {
+                                          unsigned FrameIndex) const {
   // Get the instruction.
   MachineInstr &MI = *II;       // ; SPILL_VRSAVE <SrcReg>, <offset>
   // Get the instruction's basic block.
@@ -394,8 +386,6 @@ void PPCRegisterInfo::lowerVRSAVESpillin
   // FIXME: Once LLVM supports creating virtual registers here, or the register
   // scavenger can return multiple registers, stop using reserved registers
   // here.
-  (void) SPAdj;
-  (void) RS;
 
   unsigned Reg = PPC::R0;
   unsigned SrcReg = MI.getOperand(0).getReg();
@@ -412,8 +402,7 @@ void PPCRegisterInfo::lowerVRSAVESpillin
 }
 
 void PPCRegisterInfo::lowerVRSAVERestore(MachineBasicBlock::iterator II,
-                                      unsigned FrameIndex, int SPAdj,
-                                      RegScavenger *RS) const {
+                                         unsigned FrameIndex) const {
   // Get the instruction.
   MachineInstr &MI = *II;       // ; <DestReg> = RESTORE_VRSAVE <offset>
   // Get the instruction's basic block.
@@ -423,8 +412,6 @@ void PPCRegisterInfo::lowerVRSAVERestore
   // FIXME: Once LLVM supports creating virtual registers here, or the register
   // scavenger can return multiple registers, stop using reserved registers
   // here.
-  (void) SPAdj;
-  (void) RS;
 
   unsigned Reg = PPC::R0;
   unsigned DestReg = MI.getOperand(0).getReg();
@@ -497,22 +484,22 @@ PPCRegisterInfo::eliminateFrameIndex(Mac
   // Special case for dynamic alloca.
   if (FPSI && FrameIndex == FPSI &&
       (OpC == PPC::DYNALLOC || OpC == PPC::DYNALLOC8)) {
-    lowerDynamicAlloc(II, SPAdj, RS);
+    lowerDynamicAlloc(II);
     return;
   }
 
   // Special case for pseudo-ops SPILL_CR and RESTORE_CR, etc.
   if (OpC == PPC::SPILL_CR) {
-    lowerCRSpilling(II, FrameIndex, SPAdj, RS);
+    lowerCRSpilling(II, FrameIndex);
     return;
   } else if (OpC == PPC::RESTORE_CR) {
-    lowerCRRestore(II, FrameIndex, SPAdj, RS);
+    lowerCRRestore(II, FrameIndex);
     return;
   } else if (OpC == PPC::SPILL_VRSAVE) {
-    lowerVRSAVESpilling(II, FrameIndex, SPAdj, RS);
+    lowerVRSAVESpilling(II, FrameIndex);
     return;
   } else if (OpC == PPC::RESTORE_VRSAVE) {
-    lowerVRSAVERestore(II, FrameIndex, SPAdj, RS);
+    lowerVRSAVERestore(II, FrameIndex);
     return;
   }
 

Modified: llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.h?rev=177827&r1=177826&r2=177827&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.h (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.h Sat Mar 23 14:36:47 2013
@@ -61,16 +61,15 @@ public:
     return true;
   }
 
-  void lowerDynamicAlloc(MachineBasicBlock::iterator II,
-                         int SPAdj, RegScavenger *RS) const;
-  void lowerCRSpilling(MachineBasicBlock::iterator II, unsigned FrameIndex,
-                       int SPAdj, RegScavenger *RS) const;
-  void lowerCRRestore(MachineBasicBlock::iterator II, unsigned FrameIndex,
-                       int SPAdj, RegScavenger *RS) const;
-  void lowerVRSAVESpilling(MachineBasicBlock::iterator II, unsigned FrameIndex,
-                       int SPAdj, RegScavenger *RS) const;
-  void lowerVRSAVERestore(MachineBasicBlock::iterator II, unsigned FrameIndex,
-                       int SPAdj, RegScavenger *RS) const;
+  void lowerDynamicAlloc(MachineBasicBlock::iterator II) const;
+  void lowerCRSpilling(MachineBasicBlock::iterator II,
+                       unsigned FrameIndex) const;
+  void lowerCRRestore(MachineBasicBlock::iterator II,
+                      unsigned FrameIndex) const;
+  void lowerVRSAVESpilling(MachineBasicBlock::iterator II,
+                           unsigned FrameIndex) const;
+  void lowerVRSAVERestore(MachineBasicBlock::iterator II,
+                          unsigned FrameIndex) const;
 
   bool hasReservedSpillSlot(const MachineFunction &MF, unsigned Reg,
 			    int &FrameIdx) const;





More information about the llvm-commits mailing list