[poolalloc] r177639 - Fixed comments to better inform the user how to use the DSNodeEquivs pass.

John Criswell criswell at uiuc.edu
Thu Mar 21 07:59:20 PDT 2013


Author: criswell
Date: Thu Mar 21 09:59:20 2013
New Revision: 177639

URL: http://llvm.org/viewvc/llvm-project?rev=177639&view=rev
Log:
Fixed comments to better inform the user how to use the DSNodeEquivs pass.
No functionality changes.

Modified:
    poolalloc/branches/release_32/include/assistDS/DSNodeEquivs.h
    poolalloc/branches/release_32/lib/AssistDS/DSNodeEquivs.cpp

Modified: poolalloc/branches/release_32/include/assistDS/DSNodeEquivs.h
URL: http://llvm.org/viewvc/llvm-project/poolalloc/branches/release_32/include/assistDS/DSNodeEquivs.h?rev=177639&r1=177638&r2=177639&view=diff
==============================================================================
--- poolalloc/branches/release_32/include/assistDS/DSNodeEquivs.h (original)
+++ poolalloc/branches/release_32/include/assistDS/DSNodeEquivs.h Thu Mar 21 09:59:20 2013
@@ -51,10 +51,15 @@ public:
 
   bool runOnModule(Module &M);
 
-  // Returns the computed equivalence classes.
+  // Returns the computed equivalence classes.  Two DSNodes in the same
+  // equivalence class may alias.  DSNodes may also alias if they have the
+  // Incomplete, Unknown, or External flags set (even if they are in different
+  // equivalence classes).
   const EquivalenceClasses<const DSNode*> &getEquivalenceClasses();
 
-  // Returns the DSNode in the equivalence classes for the specified value.
+  // Returns a DSNode for the specified value.  Note that two nodes may alias
+  // even if they have different DSNodes (because the DSNodes may belong to
+  // different DSGraphs).
   const DSNode *getMemberForValue(const Value *V);
 };
 

Modified: poolalloc/branches/release_32/lib/AssistDS/DSNodeEquivs.cpp
URL: http://llvm.org/viewvc/llvm-project/poolalloc/branches/release_32/lib/AssistDS/DSNodeEquivs.cpp?rev=177639&r1=177638&r2=177639&view=diff
==============================================================================
--- poolalloc/branches/release_32/lib/AssistDS/DSNodeEquivs.cpp (original)
+++ poolalloc/branches/release_32/lib/AssistDS/DSNodeEquivs.cpp Thu Mar 21 09:59:20 2013
@@ -223,7 +223,7 @@ DSNodeEquivs::getEquivalenceClasses() {
   return Classes;
 }
 
-// Returns the DSNode in the equivalence classes for the specified value.
+// Returns a DSNode for the specified value.
 // Returns null for a node that was not found.
 const DSNode *DSNodeEquivs::getMemberForValue(const Value *V) {
   TDDataStructures &TDDS = getAnalysis<TDDataStructures>();





More information about the llvm-commits mailing list