[llvm] r177465 - Propagate DAG node ordering during type legalization and instruction selection

Owen Anderson resistor at mac.com
Tue Mar 19 20:05:37 PDT 2013


On Mar 19, 2013, at 5:10 PM, Justin Holewinski <jholewinski at nvidia.com> wrote:

> A node's ordering is only propagated during legalization if (a) the new node does
> not have an ordering (is not a CSE'd node), or (b) the new node has an ordering
> that is higher than the node being legalized.

I think you need to apply the same exceptions during instruction selection as well.  Implicit CSE happens during all phases of SelectionDAG.  The simplest solution might be to move the code that handles these cases into the add() method on the node ordering object.

--Owen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130319/d2ce52aa/attachment.html>


More information about the llvm-commits mailing list