[PING] Improved TableGen support for PowerPC pre-inc operand matching

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Mon Mar 18 11:33:23 PDT 2013


Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote on 05.03.2013 19:46:10:

> This generally looks good, but please add some documentation of the
feature.
>
> Also, please break the target changes into separate patches. The X86
> issue seems almost unrelated.

Hi Jakob,

thanks for the review!  And sorry for the late reply; I've been out
sick for the last two weeks ...

I've attached an updated version of the patch that:
- breaks out just the TableGen core changes
- is updated for your latest changes (this made the patch
  actually shorter, thanks!)
- adds documentation ... I hope I found the correct place

Would this be OK?

Thanks,
Ulrich

(See attached file: diff-llvm-asm-preinc-core)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-llvm-asm-preinc-core
Type: application/octet-stream
Size: 5965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130318/c2d0bf80/attachment.obj>


More information about the llvm-commits mailing list