[Patch] Fix integer comparison in DIEInteger::BestForm

Hans Wennborg hans at chromium.org
Mon Mar 18 10:04:36 PDT 2013


Committed r177290.

Thanks,
Hans

On Mon, Mar 18, 2013 at 4:34 PM, Eric Christopher <echristo at gmail.com> wrote:
> Not surprising on the test. If you could come up with something awesome,
> otherwise I think it's fine.
>
> Thanks!
>
> -eric
>
>
> On Sun, Mar 17, 2013 at 8:23 AM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> Hi all,
>>
>> I found the always-true comparison "(int)Int == (signed)Int" in DIE.h.
>> I've attached a patch that tries to fix it. There doesn't seem to be
>> any test covering this :/
>>
>> Please take a look!
>>
>> Thanks,
>> Hans
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>



More information about the llvm-commits mailing list