[llvm] r177239 - Split out filename & directory from DIFile to start generalizing over DIScopes

David Blaikie dblaikie at gmail.com
Mon Mar 18 09:50:20 PDT 2013


On Mon, Mar 18, 2013 at 3:49 AM, Renato Golin <renato.golin at linaro.org> wrote:
> On 17 March 2013 21:13, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> Author: dblaikie
>> Date: Sun Mar 17 16:13:55 2013
>> New Revision: 177239
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=177239&view=rev
>> Log:
>> Split out filename & directory from DIFile to start generalizing over
>> DIScopes
>>
>> This is the first step to making all DIScopes have a common metadata
>> prefix (so
>> that things (using directives, for example) that can appear in any scope
>> can be
>> added to that common prefix). DIFile is itself a DIScope so the common
>> prefix
>> of all DIScopes cannot be a DIFile - instead it's the raw
>> filename/directory
>> name pair.
>
>
> Hi David,
>
> I'm not sure, but I think this commit had adverse effect on an existing
> test:
>
> http://lab.llvm.org:8011/builders/llvm-armv5-linux/builds/64/steps/test-llvm/logs/LLVM%20%3A%3A%20DebugInfo__inlined-vars.ll
>
> It could be some of the others around, since it only shows in the ARMv5 bot
> and not on any other (and the ARMv5 bot is quite slow).
>
> Looks like it didn't find any formal parameter TAG, which is odd...

Little bit odd - if you have access to this machine/hardware, can you
reproduce this failure reliably (& over this particular revision)? (I
suppose I might be able to reproduce this just by specifying the
target but I'm not sure) If possible, a test case (with the
appropriately hardcoded triple) would be great.



More information about the llvm-commits mailing list