[PATCH] Windows hang with long filename

[Aaron Ballman]

Patch looks good to me, committed in r177223.  Thanks!

~Aaron

On Wed, Mar 13, 2013 at 4:25 PM, Robinson, Paul
<Paul.Robinson at am.sony.com> wrote:
>> -----Original Message-----
>> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
>> bounces at cs.uiuc.edu] On Behalf Of Duncan Sands
>> Sent: Wednesday, March 13, 2013 2:31 AM
>> To: llvm-commits at cs.uiuc.edu
>> Subject: Re: [PATCH] Windows hang with long filename
>>
>> Hi Paul,
>>
>> On 12/03/13 22:33, Robinson, Paul wrote:
>> > This is basically the Windows version of r176226; it avoids a
>> > hang when certain issues arise with an output filename.
>> > We found this because Clang would hang because the output file
>> > pathname exceeded the Windows limit of 260 characters.
>> > Yes, I know the context around the fix is about creating the
>> > parent directory; but that's the loop where the hang occurs.
>> >
>> > Murphy consequence #1:  I could not find any LLVM tool that used
>> > unique_file(), only Clang uses this AFAICT.  So the test is written
>> > for Clang, which means it has to go in the Clang suite instead of
>> > the LLVM suite.
>>
>> can't you write an LLVM unit test for it (see the llvm/unittests
>> directory)?
>>
>> Ciao, Duncan.
>
> Ha, didn't think of that.  How does this look?
> (Please commit for me if okay.)
> Thanks,
> --paulr
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>