[llvm] r177098 - LoopVectorize: Invert case when we use a vector cmp value to query select cost

Arnold Schwaighofer aschwaighofer at apple.com
Thu Mar 14 14:32:03 PDT 2013


Sure. I will insert some white space and remove the attributes. The vim .ll syntax mode makes comments stick out so I did not notice this.

r177114

On Mar 14, 2013, at 4:20 PM, Eric Christopher <echristo at gmail.com> wrote:

> A couple of small nits here:
> 
> +
> +; CHECK: Checking a loop in "scalarselect"
> +define void @scalarselect(i1 %cond) nounwind uwtable ssp {
> 
> Don't really need the uwtable and ssp attributes here.
>  
> +; A scalar select has a cost of 1 on core2
> +; CHECK: cost of 1 for VF 2 {{.*}}  select i1 %cond, i32 %6, i32 0
> +  %sel = select i1 %cond, i32 %6, i32 zeroinitializer
> 
> The checks mid-block are _really_ hard to see. Mind hoisting or providing some vertical whitespace, or something? If you hoist you may want to comment the particular select below that you're checking on as well, but...
> 
> -eric 




More information about the llvm-commits mailing list