[PATCH] Move estimateStackSize from ARM into MachineFunction

Hal Finkel hfinkel at anl.gov
Thu Mar 14 12:45:02 PDT 2013


----- Original Message -----
> From: "Tim Northover" <t.p.northover at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "LLVM Commits" <llvm-commits at cs.uiuc.edu>
> Sent: Thursday, March 14, 2013 2:24:24 PM
> Subject: Re: [PATCH] Move estimateStackSize from ARM into MachineFunction
> 
> > Please review this patch which moves the estimateStackSize
> > function from the ARM backend into MachineFunction.
> 
> A very good idea that I should have done myself. The changes to
> estimateFrameSize look trivial and trivially correct to me.
> 
> It's a bit cheeky, but I don't suppose you could make AArch64 use the
> generic one too? Our implementation is identical to ARM's,
> byte-for-byte.

Sure, I'll do that too.

Thanks again,
Hal

> 
> Go for it regardless.
> 
> Cheers.
> 
> Tim.
> 



More information about the llvm-commits mailing list