[llvm] r176886 - [Support][MemoryBuffer] Use sys::fs::mapped_file_region instead of sys::Path::MapInFilePages.

[Argyrios Kyrtzidis]

Hi,

On Mar 12, 2013, at 12:28 PM, Michael J. Spencer <bigcheesegs at gmail.com> wrote:

>  error_code ret = getOpenFile(FD, Filename, result, FileSize, FileSize,
>                                0, RequiresNullTerminator);
> -  close(FD);
>   return ret;
> }

I believe your commit caused clang to leak file descriptors, I get a couple of test failures from "Too many open files" error (I'm on a mac):

FAIL: Clang :: Modules/compiler_builtins.m (1 of 1)
******************** TEST 'Clang :: Modules/compiler_builtins.m' FAILED ********************
Script:
--
rm -rf /Volumes/HD/Users/argiris/proj/llvm/clang-build/tools/clang/test/Modules/Output/compiler_builtins.m.tmp
/Volumes/HD/Users/argiris/proj/llvm/clang-build/Debug+Asserts/bin/clang  -fsyntax-only -fmodules -fmodules-cache-path=/Volumes/HD/Users/argiris/proj/llvm/clang-build/tools/clang/test/Modules/Output/compiler_builtins.m.tmp -D__need_wint_t /Volumes/HD/Users/argiris/proj/llvm/src/tools/clang/test/Modules/compiler_builtins.m -Xclang -verify
/Volumes/HD/Users/argiris/proj/llvm/clang-build/Debug+Asserts/bin/clang  -fsyntax-only -std=c99 -fmodules -fmodules-cache-path=/Volumes/HD/Users/argiris/proj/llvm/clang-build/tools/clang/test/Modules/Output/compiler_builtins.m.tmp -D__need_wint_t /Volumes/HD/Users/argiris/proj/llvm/src/tools/clang/test/Modules/compiler_builtins.m -Xclang -verify
--
Exit Code: 1
Command Output (stderr):
--
error: no expected directives found: consider use of 'expected-no-diagnostics'
error: 'error' diagnostics seen but not expected: 
  Line 82: cannot open file '/usr/include/mach/host_special_ports.h': Too many open files
2 errors generated.


There are no test failures if I revert your commit.
Could you revert and investigate please ?

-Argyrios
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130313/6837cd7f/attachment.html>