[PATCH] [RFC][5/17]TILE-Gx: add register information for tilegx

Jiong Wang jiwang at tilera.com
Mon Mar 11 19:10:55 PDT 2013


于 2013/3/12 1:24, Jakob Stoklund Olesen 写道:
> On Mar 11, 2013, at 8:15 AM, Anton Korobeynikov <anton at korobeynikov.info> wrote:
>
>> Comment at: lib/Target/Tile/TileRegisterInfo.td:173
>> @@ +172,3 @@
>> +  // Return Values and Arguments, caller saved.
>> +  R0_32, R1_32, R2_32, R3_32, R4_32, R5_32, R6_32, R7_32, R8_32, R9_32,
>> +  // Other caller saved.
>> ----------------
>> You can simplify these list a lot using sequences. See ARMInstrInfo.td for reference
> And there is no need to put volatile registers before the callee saved ones etc. That's done automatically now by RegisterClassInfo.

Hi Jakob,

thanks for your time to review. Have you misread this as 
TileCallingConv.td? For RegisterClass description, I think we need to 
add all registers.

---
Regards,
Jiong
Tilera Corporation
>
> /jakob
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list