[PATCH] Test-suite McCat signed char

[Renato Golin]

Thanks! r176549.

--renato


On 6 March 2013 17:09, Kristof Beyls <kristof.beyls at arm.com> wrote:

> LGTM.****
>
> ** **
>
> *From:* Renato Golin [mailto:renato.golin at linaro.org]
> *Sent:* 05 March 2013 09:44
> *To:* Kristof Beyls
> *Cc:* LLVM Commits
> *Subject:* Re: [PATCH] Test-suite McCat signed char****
>
> ** **
>
> Updated, as a comment.****
>
> ** **
>
> --renato****
>
> ** **
>
> On 5 March 2013 17:37, Renato Golin <renato.golin at linaro.org> wrote:****
>
> On 5 March 2013 17:28, Kristof Beyls <kristof.beyls at arm.com> wrote:****
>
> might be better written as just an unconditional “typedef signed char
> char_t” for all architectures.****
>
> Maybe a one-line comment would be useful to state that the test relies on
> chars being signed, and that chars are not signed by default on all
> architectures?****
>
> ** **
>
> That's also an option.****
>
> ** **
>
> ** **
>
> By dropping the “ifdef __arm__” part, the test would also be fixed on any
> other architectures on which chars are unsigned by default.****
>
> ** **
>
> Are there any others? ;)****
>
> ** **
>
> --renato****
>
> ** **
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130306/c87dab45/attachment.html>