[PATCH] Fix remaining issue in PR15355

Michael Liao michael.liao at intel.com
Tue Mar 5 18:54:49 PST 2013


Hi All,

The attached patch fixes a remaining issue after fixing PR15355. When
CMOV is not available, the phi node created in advanced needs replacing
with a new one. One of that Phi node's BB operand creating these
operands will be changed after lowering CMOV into branches. The attached
patch fixes them by replacing these phi nodes and adds a workaround for
machine code verifier.

BTW, it seems X86 attributes (e.g. -mattr=+cmov) is not properly
propagated in non-x86 builds, quite weird. I have no way to verify them
on these builds but could only verify it with '-attr=-cmov' on X86
build. Please let me immediately if any non-X86 builds still fail with
this patch.

Thanks for your review
- Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-two-remaining-issue-after-fixing-PR15355-when-CM.patch
Type: text/x-patch
Size: 7859 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130305/c29a62fc/attachment.bin>


More information about the llvm-commits mailing list