[PATCH] Test-suite McCat signed char

Renato Golin renato.golin at linaro.org
Tue Mar 5 01:37:26 PST 2013


On 5 March 2013 17:28, Kristof Beyls <kristof.beyls at arm.com> wrote:

> might be better written as just an unconditional “typedef signed char
> char_t” for all architectures.
>
> Maybe a one-line comment would be useful to state that the test relies on
> chars being signed, and that chars are not signed by default on all
> architectures?
>

That's also an option.


****
>
> By dropping the “ifdef __arm__” part, the test would also be fixed on any
> other architectures on which chars are unsigned by default.
>

Are there any others? ;)

--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130305/0c739271/attachment.html>


More information about the llvm-commits mailing list