[PATCH] <<Proposed Driver Update>>

Shankar Kalpathi Easwaran shankarke at gmail.com
Sun Mar 3 18:32:41 PST 2013


  other than the above comment, changes LGTM.


================
Comment at: include/lld/ReaderWriter/MachOTargetInfo.h:23-26
@@ -23,1 +22,6 @@
 
+namespace mach_o {
+  class KindHandler;  // defined in lib. this header is in include.
+}
+
+class MachOTargetInfo : public TargetInfo {
----------------
ELF moved the functionality of kindHandler to relocation Handler, for consistency, it may be good to change kindHandler to relocationHandler too.


http://llvm-reviews.chandlerc.com/D481



More information about the llvm-commits mailing list