[PATCH] Handle non-pic code in the ARMISelLowering::EmitSjLjDispatchBlock function

Chad Rosier mcrosier at apple.com
Fri Mar 1 10:35:39 PST 2013


On Mar 1, 2013, at 10:09 AM, Jim Grosbach <grosbach at apple.com> wrote:

> LGTM.

Committed revision 176363.

> 
> What prevented running the test for Thumb1?

With a little assistance from Jim I was able to test thumb1 as well.  Thanks, Jim.

 Chad

> 
> On Mar 1, 2013, at 10:09 AM, Chad Rosier <mcrosier at apple.com> wrote:
> 
>> All,
>> The attached patch adds support for using non-pic code for thumb1 and arm when emitting the sjlj
>> dispatch code.  As far as I can tell the thumb2 code is behaving as expected.  I was able to compile
>> and run the attached test case for arm.  Unfortunately, I wasn't able to do the same for thumb1.  The
>> changes are mechanically equivalent between arm and thumb1, but I'd still prefer to have the code
>> reviewed.
>> 
>> Regards,
>>  Chad
>> 
>> <arm-dispcont-nonpic.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130301/8cfd963e/attachment.html>


More information about the llvm-commits mailing list