[test-suite] r176238 - Change 252.eon and 447.dealII to explicitly build with libstdc++.

[Bob Wilson]

On Feb 28, 2013, at 12:37 PM, Eric Christopher <echristo at gmail.com> wrote:

> 
> 
> 
> On Thu, Feb 28, 2013 at 12:35 PM, Bob Wilson <bob.wilson at apple.com> wrote:
> If they were bugs in libc++, I wouldn't have done this!
> 
> 
> Heh. Mostly meant "hey, workaround to test the rest of the compiler while waiting on libc++" as a possibility.
>  
> There were multiple problems.  These are old C++ programs using non-standard libstdc++ headers and doing other bad stuff.
> 
> 
> Ick.
> 
> Thanks :)
> 
> -eric

The comment before this part of the patch really says everything that needs to be said:

# Yes, we know this is an old crufty C++ benchmark.  Don't tell us about it GCC!
-CXXFLAGS += -fno-exceptions -Wno-deprecated -Wno-non-template-friend -fpermissive
+CXXFLAGS += -fno-exceptions -Wno-deprecated -Wno-non-template-friend -fpermissive -stdlib=libstdc++

447.dealII was not quite so bad.

>  
> 
> On Feb 28, 2013, at 12:29 PM, Eric Christopher <echristo at gmail.com> wrote:
> 
>> Curiosity:
>> 
>> What issues? Bug in libc++ or the testcase?
>> 
>> -eric
>> 
>> 
>> On Wed, Feb 27, 2013 at 11:57 PM, Bob Wilson <bob.wilson at apple.com> wrote:
>> Author: bwilson
>> Date: Thu Feb 28 01:57:20 2013
>> New Revision: 176238
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=176238&view=rev
>> Log:
>> Change 252.eon and 447.dealII to explicitly build with libstdc++.
>> They both have issues when using libc++.
>> 
>> Modified:
>>     test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile
>>     test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile
>> 
>> Modified: test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile
>> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile?rev=176238&r1=176237&r2=176238&view=diff
>> ==============================================================================
>> --- test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile (original)
>> +++ test-suite/trunk/External/SPEC/CFP2006/447.dealII/Makefile Thu Feb 28 01:57:20 2013
>> @@ -16,6 +16,7 @@ CPPFLAGS += \
>>          -Ddeal_II_dimension=3     \
>>          -DBOOST_DISABLE_THREADS   \
>>          -I$(SPEC_BENCH_DIR)/src/include
>> +CXXFLAGS += -stdlib=libstdc++
>> 
>>  STDOUT_FILENAME := log
>> 
>> 
>> Modified: test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile
>> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile?rev=176238&r1=176237&r2=176238&view=diff
>> ==============================================================================
>> --- test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile (original)
>> +++ test-suite/trunk/External/SPEC/CINT2000/252.eon/Makefile Thu Feb 28 01:57:20 2013
>> @@ -57,7 +57,7 @@ Source = $(addprefix $(SPEC_BENCH_DIR)/s
>>              mrXYRectangle.cc mrXZRectangle.cc mrYZRectangle.cc myrand.cc)
>> 
>>  # Yes, we know this is an old crufty C++ benchmark.  Don't tell us about it GCC!
>> -CXXFLAGS += -fno-exceptions -Wno-deprecated -Wno-non-template-friend -fpermissive
>> +CXXFLAGS += -fno-exceptions -Wno-deprecated -Wno-non-template-friend -fpermissive -stdlib=libstdc++
>> 
>>  LDFLAGS = -lstdc++ -lm
>>  LIBS    = -lm
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130228/45e47e0d/attachment.html>