[llvm] r176214 - The FastISEL should be fast. But when we record statistics we use atomic operations to increment the counters.

[Eric Christopher]

On Thu, Feb 28, 2013 at 9:13 AM, Nadav Rotem <nrotem at apple.com> wrote:

> Hi Eric,
>
> This is what I was talking about that Nadav never bothered to respond to.
>
>
> You wrote me less than 24 hours ago, and I did not have time to write
> back.
>
>
Yeah, sorry about that I was just responding to myself and the list about
that.
My apologies.


> Whether or not it made sense to put all of the statistics as only firing
> during
> debug builds and then making the change in the statistics framework rather
> than #if NDEBUG for each set of statistics and the assorted increments.
>
>
> I don't have any preference. Do you prefer one way or the other ?
>
> I kept NumDAGBlocks and NumFastIselBlocks, because they are called once
> per blocks and not once per instructions. I don't mind if we put them
> behind #ifndef NDEBUG as well.
>

It's why I was asking, I think it might be an interesting idea to put all
the statistics
behind NDEBUG so we can feel free to collect stats whenever rather than
needing to worry about putting the high firing status under NDEBUG
explicitly.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130228/0aa5bf43/attachment.html>