[PATCH] [lld][ELF][x86-64] Separate static and dynamic GOT/PLT generation.

Shankar Kalpathi Easwaran shankarke at gmail.com
Wed Feb 27 21:27:24 PST 2013


  Other than this comment, it LGTM


================
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64TargetInfo.h:61
@@ +60,3 @@
+    case llvm::ELF::R_X86_64_JUMP_SLOT:
+    case llvm::ELF::R_X86_64_GLOB_DAT:
+    case llvm::ELF::R_X86_64_IRELATIVE:
----------------
GLOB_DAT :- Isnt this a relocation that needs to be created in .rela.dyn as opposed to .rela.plt ?


http://llvm-reviews.chandlerc.com/D476



More information about the llvm-commits mailing list