[lld] r176167 - adding a return to fix compilation error from buildbot, build #75

David Blaikie dblaikie at gmail.com
Tue Feb 26 21:46:45 PST 2013


On Tue, Feb 26, 2013 at 9:33 PM, Shankar Easwaran
<shankare at codeaurora.org> wrote:
> Author: shankare
> Date: Tue Feb 26 23:33:27 2013
> New Revision: 176167
>
> URL: http://llvm.org/viewvc/llvm-project?rev=176167&view=rev
> Log:
> adding a return to fix compilation error from buildbot, build #75
>
> Modified:
>     lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationFunctions.h
>
> Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationFunctions.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationFunctions.h?rev=176167&r1=176166&r2=176167&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationFunctions.h (original)
> +++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonRelocationFunctions.h Tue Feb 26 23:33:27 2013
> @@ -40,6 +40,7 @@ uint32_t findBitMask(uint32_t insn, Inst
>        return encodings[i].insnBitMask;
>    }
>    assert(0 && "found unknown instruction");
> +  return 0;

Replacing this (both the assert and return) with
llvm_unreachable("found unknown instruction") should fix the build &
would be preferred.

>  }
>
>  } // elf
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list