[llvm] r176022 - Fix the root cause of PR15348 by correctly handling alignment 0 on

Bill Wendling wendling at apple.com
Tue Feb 26 16:51:00 PST 2013


On Feb 25, 2013, at 6:20 AM, Chandler Carruth <chandlerc at gmail.com> wrote:

> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp?rev=176022&r1=176021&r2=176022&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Mon Feb 25 08:20:21 2013
> @@ -3867,6 +3867,7 @@ SDValue SelectionDAG::getMemcpy(SDValue
>                                 unsigned Align, bool isVol, bool AlwaysInline,
>                                 MachinePointerInfo DstPtrInfo,
>                                 MachinePointerInfo SrcPtrInfo) {
> +  assert(Align && "The SDAG layer expects explicit alignment and reservers 0");
> 
Did you mean "reserves"?

-bw

>   // Check to see if we should lower the memcpy to loads and stores first.
>   // For cases within the target-specified limits, this is the best choice.
> @@ -3934,6 +3935,7 @@ SDValue SelectionDAG::getMemmove(SDValue
>                                  unsigned Align, bool isVol,
>                                  MachinePointerInfo DstPtrInfo,
>                                  MachinePointerInfo SrcPtrInfo) {
> +  assert(Align && "The SDAG layer expects explicit alignment and reservers 0");
> 
>   // Check to see if we should lower the memmove to loads and stores first.
>   // For cases within the target-specified limits, this is the best choice.
> @@ -3988,6 +3990,7 @@ SDValue SelectionDAG::getMemset(SDValue
>                                 SDValue Src, SDValue Size,
>                                 unsigned Align, bool isVol,
>                                 MachinePointerInfo DstPtrInfo) {
> +  assert(Align && "The SDAG layer expects explicit alignment and reservers 0");
> 
>   // Check to see if we should lower the memset to stores first.
>   // For cases within the target-specified limits, this is the best choice.
> 





More information about the llvm-commits mailing list