[dragonegg] r176016 - Format with clang-format.

Sean Silva silvas at purdue.edu
Tue Feb 26 10:43:49 PST 2013


On Tue, Feb 26, 2013 at 8:20 AM, Daniel Jasper <djasper at google.com> wrote:
>
>
>
> On Mon, Feb 25, 2013 at 8:14 PM, Sean Silva <silvas at purdue.edu> wrote:
>>
>>      for (SmallSetVector<Constant *, 32>::iterator AI =
>> -             AttributeCompilerUsedGlobals.begin(), AE =
>> -             AttributeCompilerUsedGlobals.end();
>> +             AttributeCompilerUsedGlobals
>> +                 .begin(), AE = AttributeCompilerUsedGlobals.end();
>>           AI != AE; ++AI) {
>>
>>
>> This looks a bit dubious.
>
>
> This was fixed last week and now gets formatted as:
>
> for (SmallSetVector<Constant *, 32>::iterator
>          AI = AttributeCompilerUsedGlobals.begin(),
>          AE = AttributeCompilerUsedGlobals.end();
>      AI != AE; ++AI)
>
> Which is IMO an even better solution.

Indeed! That looks fantastic.

-- Sean Silva



More information about the llvm-commits mailing list