[PATCH 1/9] R600/SI: fix stupid typo

Sean Silva silvas at purdue.edu
Mon Feb 25 18:33:18 PST 2013


On Mon, Feb 25, 2013 at 3:00 PM, Tom Stellard <tom at stellard.net> wrote:

> Can you clarify this?  Do you mean one email with with all the patches
> as attachments?


That would be preferable. Note that gmail (which many of us use) doesn't
respect threading (instead it arbitrarily threads based on subject for some
reason), so having them all as replies will still flood the inbox of gmail
users.

However, it is much more in line with LLVM development style to send in
patches incrementally for review rather than dumping a whole branch; that
ensures focused review.

(I'll also reiterate how troubling it is that none of these R600 changes
have unit tests).

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130225/dc940b96/attachment.html>


More information about the llvm-commits mailing list